Skip to content

kola-denylist: drop the crio.base test from the list #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miabbott wants to merge 1 commit into from
Closed

kola-denylist: drop the crio.base test from the list #573

miabbott wants to merge 1 commit into from

Conversation

@miabbott
Copy link
Member

@miabbott miabbott commented Jun 28, 2021

The upstream issue linked for the denylist entry was fixed/closed back
in Feb 2020, so let's turn on the tests again and see how we do.

@miabbott
kola-denylist: drop the crio.base test from the list
144f09d 
The upstream issue linked for the denylist entry was fixed/closed back
in Feb 2020, so let's turn on the tests again and see how we do.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from jlebon and lucab June 28, 2021 17:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@miabbott
Copy link
Member Author

miabbott commented Jun 28, 2021

@ravanelli @jschintag Could you folks run the crio.base test against an RHCOS on ppc64le and s390x to see if this is actually fixed?

@travier
Copy link
Member

travier commented Jun 29, 2021

This is something I forgot to do. We should update the tracking issue to the one removed in 30827e8 which is the failure still happening in ppcle64 and s390x AFAIR.

@travier
Copy link
Member

travier commented Jun 29, 2021

Checking again is good too

@ravanelli
Copy link
Member

ravanelli commented Jun 29, 2021

@ravanelli @jschintag Could you folks run the crio.base test against an RHCOS on ppc64le and s390x to see if this is actually fixed?

Missed that yesterday. Will check it now

@ravanelli
Copy link
Member

ravanelli commented Jul 1, 2021

@miabbott

It finally passed for ppc64le, I used the cosa 4.8 with your OS branch for the tests:
https://jenkins-rhcos-dev.cloud.p8.psi.redhat.com/job/rhcos-dev/job/rhcos-dev-koji-test/53/consoleFull

=== RUN   crio.base/crio-info
=== RUN   crio.base/pod-continues-during-service-restart
--- PASS: ext.config.root-reprovision.raid1 (258.81s)
=== RUN   crio.base/networks-reliably
--- PASS: rpmostree.status (63.19s)
--- PASS: coreos.selinux.boolean (109.03s)
--- PASS: crio.base (201.87s)
    --- PASS: crio.base/crio-info (0.22s)
    --- PASS: crio.base/pod-continues-during-service-restart (62.56s)
            cluster.go:141: Getting image source signatures
            cluster.go:141: Copying blob sha256:a20cf556866d756c72590201d5fb3027321066adf14bc8ec005b99694f1b54e1
            cluster.go:141: Copying config sha256:792b2ed15a361af823a7521ae4003701faa9487bd55e7c5d8b85f2ca372c9bdf
            cluster.go:141: Writing manifest to image destination
            cluster.go:141: Storing signatures
    --- PASS: crio.base/networks-reliably (58.05s)
            cluster.go:141: Getting image source signatures
            cluster.go:141: Copying blob sha256:6e85d77a23870fccec00db8042792297dc87d449c026c49cc08eef5a24883255
            cluster.go:141: Copying config sha256:19bd41fab83d5121381bf3e611c25cbd4bf0798b9a91a82c287437de69b246da
            cluster.go:141: Writing manifest to image destination
            cluster.go:141: Storing signatures

@cgwalters
Copy link
Member

cgwalters commented Jul 26, 2021

Looks like this one can be un-drafted and merged!

@travier
Copy link
Member

travier commented Jul 26, 2021

We might need a check for s390x?

@jschintag
Copy link
Contributor

jschintag commented Jul 27, 2021

Currently the test is not working on s390x, though not for the original reason. While the pause image is now available on s390x, it seems there is a problem with pulling it for crio.

[jschinta@m8345043 rhcos]$ cosa kola run crio.base
COREOS_ASSEMBLER_CONTAINER=localhost/coreos-assembler:4.8
+ podman run --rm -ti --security-opt label=disable --privileged --uidmap=1000:0:1 --uidmap=0:1:1000 --uidmap 1001:1001:64536 -v /home/jschinta/rhcos:/srv/ --device /dev/kvm --device /dev/fuse --tmpfs /tmp -v /var/tmp:/var/tmp --name cosa localhost/coreos-assembler:4.8 kola run crio.base
⚠️  Skipping kola test pattern "fips.enable*":
⚠️  https://bugzilla.redhat.com/show_bug.cgi?id=1782026
⚠️  Skipping kola test pattern "ext.config.var-mount":
⚠️  https://github.com/ibm-s390-tools/s390-tools/pull/82
⚠️  Skipping kola test pattern "coreos.ignition.journald-log":
⚠️  https://github.com/coreos/coreos-assembler/issues/1173
kola --denylist-test fips.enable* --denylist-test ext.config.var-mount --denylist-test coreos.ignition.journald-log -p qemu-unpriv --output-dir tmp/kola run crio.base
=== RUN   crio.base
=== RUN   crio.base/crio-info
=== RUN   crio.base/pod-continues-during-service-restart
=== RUN   crio.base/networks-reliably
--- FAIL: crio.base (865.54s)
    --- PASS: crio.base/crio-info (1.92s)
    --- FAIL: crio.base/pod-continues-during-service-restart (48.36s)
            cluster.go:141: Getting image source signatures
            cluster.go:141: Copying blob sha256:291fcb6b76153b3f9791ca7c436285d94e5332995e0f905647540e973eafad0c
            cluster.go:141: Copying config sha256:4d884bd0af2f41b1e6176277091a3f06e1c9634830d8ac996515589a8d92a12b
            cluster.go:141: Writing manifest to image destination
            cluster.go:141: Storing signatures
            cluster.go:141: time="2021-07-27T06:52:13Z" level=fatal msg="run pod sandbox: rpc error: code = Unknown desc = error creating pod sandbox with name \"k8s_rhcos-crio-pod-restart-test_redhat.test.crio__0\": Error initializing source docker://k8s.gcr.io/pause:3.5: error pinging docker registry k8s.gcr.io: Get \"https://k8s.gcr.io/v2/\": dial tcp: lookup k8s.gcr.io on [::1]:53: read udp [::1]:59789->[::1]:53: read: connection refused"
            cluster.go:164: "sudo crictl runp restart-testPod261888986" failed: output , status Process exited with status 1
    --- PASS: crio.base/networks-reliably (667.32s)
            cluster.go:141: Getting image source signatures
            cluster.go:141: Copying blob sha256:34c37470e52b8d5b04f4b1f3c92631ed1d108b2a237f1ae468ca5f9b5b5dab2b
            cluster.go:141: Copying config sha256:16fb5807874cdd7c945340812650f3b022c98b61f9ce2be9172af45f148d7da7
            cluster.go:141: Writing manifest to image destination
            cluster.go:141: Storing signatures
FAIL, output in tmp/kola
Error: harness: test suite failed
2021-07-27T07:03:22Z cli: harness: test suite failed
+ rc=1
+ set +x

@miabbott
Copy link
Member Author

miabbott commented Jul 27, 2021

Keeping this as draft; now disabling for all arches #595

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@miabbott: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021
@miabbott miabbott closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlebon jlebon Awaiting requested review from jlebon

@lucab lucab Awaiting requested review from lucab

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miabbott @travier @ravanelli @cgwalters @jschintag